Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Footer changelog: Update to include layout grid #2396

Merged
merged 2 commits into from Dec 13, 2023

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Dec 12, 2023

Summary

Updated changelog entry for uswds/uswds#5289 to include a note about layout grid.

Preview link

Footer changelog →

Problem statement

Users who import footer but not layout-grid may experience visual regressions if they've:

  • Modified standard breakpoint utility classes in the markup of the footer
  • Use layout-grid utilities elsewhere on the site

Solution

Update changelog to alert users of this change:

This update reduces the footer package size. Thanks @danbrady! (#5289)

If you notice changes in your layout after making this update, your Sass might be missing the usa-layout-grid package. You can include it by adding @forward usa-layout-grid to your Sass entry point.

Testing and review

  1. Inspect updated changelog
  2. Confirm it is appearing appropriately
  3. Approve spelling and grammar

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahoneycm Added a comment to possibly shorten the entry.

_data/changelogs/component-footer.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mejiaj mejiaj merged commit 6d07182 into main Dec 13, 2023
11 checks passed
@mejiaj mejiaj deleted the cm-changelog-footer-grid branch December 13, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants