Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Changelog: Add entry for indeterminate checkboxes #2482

Merged
merged 6 commits into from Apr 26, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Feb 9, 2024

Summary

Adds changelog entry for uswds/uswds#5713

Added indeterminate styles for checkboxes. Checkboxes will now display as indeterminate when input.indeterminate = true is set via JS or the data-indeterminate attribute is present. This is currently only a style addition and does not affect checkbox functionality.

Preview link

Checkbox changelog →

Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mejiaj mejiaj changed the title USWDS-Site - Changelog: Add entry for indeterminate checkboxes [#5713] USWDS-Site - Changelog: Add entry for indeterminate checkboxes Mar 5, 2024
@mahoneycm mahoneycm requested a review from amyleadem March 5, 2024 18:34
@mahoneycm mahoneycm changed the base branch from release-3.8.0 to main March 22, 2024 16:04
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahoneycm
Copy link
Contributor Author

@thisisdano Looks like this got left out in the 3.8.0 changelogs. Updated with the latest and ready for final review! 👍

@@ -2,6 +2,14 @@ title: Checkbox
type: component
changelogURL:
items:
- date: 2024-03-11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

We should update the changelog date before merge

@thisisdano thisisdano merged commit 148db21 into main Apr 26, 2024
2 of 6 checks passed
@thisisdano thisisdano deleted the cm-changelog-5713 branch April 26, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants