New Homepage #255
New Homepage #255
Conversation
|
I added a preview link to this. |
There was a problem hiding this comment.
I've only looked at this on IE11 so far but I found one blocker (I think). I'll review the code separately, if that's okay.
On IE11, the GSA logo at the bottom of the page looks tiny:
Also, the diamond in the middle of the horizontal rule-type-thing is smooshed in IE11:
The latter might be okay, since it's a decorative flourish that might be acceptable to degrade on IE11, but the former seems like a blocker...
css/styleguide.scss
Outdated
| } | ||
|
|
||
| // Override for 4x1 media grid when it collapses to 2x2 | ||
| @media screen and (max-width: 1200px) and (min-width: 600px) { |
There was a problem hiding this comment.
Interesting, there aren't any SASS variables we can reuse instead of hard-coding 1200px and 600px here? Just curious, I'm not very familiar w/ the USWDS SASS/CSS yet.
toolness
dismissed
their stale review
Oops, didn't realize that the footer image wasn't actually part of this PR!
|
Um, I don't seem to have the ability to re-review a PR once I've dismissed it, so I guess I'll just leave a comment here... I looked at the code and it looks good! I say 🚢 if you are OK with the smooshed diamond on IE11. I've filed the footer bug separately as #331. |
👀 Preview on Federalist
The post-1.0 homepage to go out with 1.1.0