Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Add search accessibility tests page #2694

Merged
merged 37 commits into from
Jun 19, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented May 24, 2024

Summary

Added accessibility tests page for the search component.

Important

We should update changelog dates before merging.

Related issue

Closes #2626

Preview link

Resources

Testing and review

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm new 3.2.3 wcag criterion is accurate and link works
  8. Confirm no visual issues.
  9. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@mahoneycm mahoneycm marked this pull request as ready for review May 24, 2024 15:36
@mahoneycm mahoneycm changed the title Create Search accessibility test page USWDS-Site: Add search accessibility tests page May 24, 2024
Copy link

@amycole501 amycole501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! Here are a few edits:

This check "A mouse is not required to perform actions in the search component" has the wrong WCAG success criteria.
I think it's just Keyboard https://www.w3.org/WAI/WCAG21/Understanding/keyboard.html

Search field...adjust on mobile check needs to have "orientation" as it's success criteria https://www.w3.org/WAI/standards-guidelines/wcag/new-in-21/#134-orientation-aa

Screen reader announces that search results will be displayed.
That success criteria should be for "on input" https://www.w3.org/WAI/WCAG22/Understanding/on-input.html
also
"where" needs to be "will" in this sentence: "When you complete a search using a screen reader, you are informed where search results where (WILL) appear."

Committing some text changes.
Committing a change to the subheader
Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed some text tweaks and also left a query about a test I think could use additional clarity.

_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
@mahoneycm mahoneycm requested a review from sarah-sch May 29, 2024 16:24
@mahoneycm
Copy link
Contributor Author

@sarah-sch Thanks for making those changes! I updated the focus indicator summary to match your recommendation and it's ready for you re-review!

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I added some questions and comments below. Please let me know if you have any questions

_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
mahoneycm and others added 4 commits May 30, 2024 10:51
@finekatie finekatie removed their request for review June 5, 2024 18:15
mahoneycm and others added 6 commits June 5, 2024 14:45
Deleting extraneous text
Adding missing period.
Fixing comma splice
Adding a missing period
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the thorough discussion on these items, team. I had a few more items for your review. Please let me know if you have any questions.

_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/changelogs/component-search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
@mahoneycm mahoneycm requested a review from amyleadem June 12, 2024 15:14
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting close! I found a couple other small edits, but hopefully they are quick to resolve.

Also, could you pull in main to (hopefully) resolve the build errors?

_data/accessibility-tests/search.yml Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
mahoneycm and others added 6 commits June 12, 2024 16:07
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm mahoneycm requested a review from amyleadem June 13, 2024 14:08
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close! Just a couple of small things I found after doing another read through

_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/search.yml Outdated Show resolved Hide resolved
mahoneycm and others added 2 commits June 13, 2024 16:12
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm mahoneycm requested a review from amyleadem June 14, 2024 13:39
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Note

The build errors should be resolved after we merge in #2710 Done!

Copy link

@alex-hull alex-hull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I approve! Food for thought for WAY later in the future. Wondering if we will be able to begin adding a section for speech dictation, so we don't have to combine the label in name criteria for screen reader and speech.

@thisisdano thisisdano merged commit 8dd2a95 into main Jun 19, 2024
11 checks passed
@thisisdano thisisdano deleted the cm-a11y-checklist-search branch June 19, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC a11y: publish Search checklist - create PR
7 participants