Merge pull request #2932 from uswds/fix-external-link

Update external link example to use hyphen
uswds · Mar 11, 2019 · 92e1bf9 · 92e1bf9
2 parents 46f4695 + ecdc709
commit 92e1bf9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/components/01-type/links.njk b/src/components/01-type/links.njk
@@ -2,7 +2,7 @@
 
 <p><a class="usa-link usa-color-text-visited" href="javascript:void(0);">This</a> is a visited link.</p>
 
-<p>This is a link that goes to an <a class="usa-link usa-external_link" href="https://media.giphy.com/media/8sgNa77Dvj7tC/giphy.gif">external website</a>.</p>
+<p>This is a link that goes to an <a class="usa-link usa-link--external" href="https://media.giphy.com/media/8sgNa77Dvj7tC/giphy.gif">external website</a>.</p>
 
 <div class="usa-background-dark">
   <p><a class="usa-link" href="javascript:void(0);">This</a> is a text link on a dark background.</p>

diff --git a/src/stylesheets/elements/_typography.scss b/src/stylesheets/elements/_typography.scss
@@ -41,12 +41,12 @@ html {
 // [href^="http:"]:not([href*="my-domain.com"])
 // [href^="https:"]:not([href*="my-domain.com"])
 
-.usa-external-link {
+.usa-link--external {
   @include external-link(external-link, external-link-hover);
-}
 
-.usa-external-link-alt {
-  @include external-link(external-link-alt, external-link-alt-hover);
+  &.usa-link--alt {
+    @include external-link(external-link-alt, external-link-alt-hover);
+  }
 }
 
 // Remove user agent styles