Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if we should we run codeclimate on the 2.0 branch(es) #2856

Closed
thisisdano opened this issue Oct 16, 2018 · 2 comments
Closed

Determine if we should we run codeclimate on the 2.0 branch(es) #2856

thisisdano opened this issue Oct 16, 2018 · 2 comments
Assignees

Comments

@thisisdano
Copy link
Member

Let's look at how and why we use codeclimate and the implications of adding codeclimate to our 2.0 CI. Do we need to update our tests? Will we find unacceptable complexity? To satisfy this issue we should determine:


  • What is Codeclimate testing on our master/develop branches?
  • Should we use it on the 2.0 branch(es)
  • Do we need to update code or tests to make the integration a success?
  • Suggest test or code improvements, if necessary.
@saracope
Copy link
Contributor

Code Climate will only run on the default branch. It sounds like it may not be getting fully approved to use.

I will look at codecov.io as was suggested.

@maya
Copy link
Contributor

maya commented Apr 11, 2019

The 2.0 branch merged into develop (the default branch), so this is no longer relevant. Though if we need to migrate to a different code coverage platform, that can be opened in a new issue.

@maya maya closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants