Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Node LTS #5010

Closed
2 tasks done
thisisdano opened this issue Nov 1, 2022 · 2 comments · Fixed by #5560
Closed
2 tasks done

Update to latest Node LTS #5010

thisisdano opened this issue Nov 1, 2022 · 2 comments · Fixed by #5560
Assignees
Labels
Affects: Build Relates to the build process Affects: Compiling Related to compiling Sass or JavaScript Affects: Dependencies Relates to project dependencies Context: JavaScript Issue is in JavaScript Is: Internal Internal issue Role: Dev Development/engineering skills needed Type: Feature Request New functionality
Milestone

Comments

@thisisdano
Copy link
Member

thisisdano commented Nov 1, 2022

Is your feature request related to a problem? Please describe.

USWDS tries to stay at the current Node LTS, which is currently 18.12.2 18.18.1. Our nvmrc file pins us to Node 16.

Describe the solution you'd like

Let's update to the current LTS (18.12.2 18.18.1) and update our nvmrc and our CI settings to match, for both the uswds and uswds-site repos at first. But each of our repos should use the current LTS.

Describe alternatives you've considered

These isn't a problem with the current setup, so an alternative is to do nothing

Additional context

No response

Code of Conduct

@thisisdano thisisdano added Type: Feature Request New functionality Status: Triage We're triaging this issue and grooming if necessary labels Nov 1, 2022
@thisisdano thisisdano self-assigned this Nov 1, 2022
@thisisdano
Copy link
Member Author

thisisdano commented Nov 1, 2022

I'm going to mark this as blocked since current Storybook uses Webpack 4 and Webpack 4 does not support Node 17 and higher. We'll need to wait until we can build with Storybook 7 and Webpack 5 to make this upgrade. Since there doesn't seem to be any compelling reason to upgrade to the most recent LTS, we'll just revisit later.

Source: storybookjs/storybook#19692

@thisisdano thisisdano added Status: Blocked 🔴 Something's preventing us from addressing this issue and removed Status: Triage We're triaging this issue and grooming if necessary labels Nov 1, 2022
@mejiaj mejiaj self-assigned this Oct 6, 2023
@mejiaj
Copy link
Contributor

mejiaj commented Oct 6, 2023

We need to schedule this due to Cloud Pages dropping support for Node 16 - cloud-gov/pages-build-container#437.

Semi-related to #5239.

@mejiaj mejiaj added Is: Internal Internal issue Affects: Build Relates to the build process Affects: Dependencies Relates to project dependencies Role: Dev Development/engineering skills needed Context: JavaScript Issue is in JavaScript Affects: Compiling Related to compiling Sass or JavaScript and removed Status: Blocked 🔴 Something's preventing us from addressing this issue labels Oct 13, 2023
@mejiaj mejiaj added this to the uswds 3.7.0 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Build Relates to the build process Affects: Compiling Related to compiling Sass or JavaScript Affects: Dependencies Relates to project dependencies Context: JavaScript Issue is in JavaScript Is: Internal Internal issue Role: Dev Development/engineering skills needed Type: Feature Request New functionality
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants