Fix validation design #2994
Merged
Fix validation design #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maya
commented
Mar 25, 2019
| @@ -128,3 +128,15 @@ $padding-left: units($theme-alert-padding-x) + units($theme-alert-bar-width); | |||
| padding-left: 0; | |||
| } | |||
| } | |||
|
|
|||
| .usa-alert--validation { | |||
There was a problem hiding this comment.
Is validation a variant of alert?
maya
commented
Mar 25, 2019
| } | ||
|
|
||
| .usa-checklist { | ||
| margin-top: units(2); |
There was a problem hiding this comment.
Margin is overruled when applied directly to .usa-checklist by .usa-alert ul so had to add a stronger selector.
thisisdano
reviewed
Mar 27, 2019
thisisdano
reviewed
Mar 27, 2019
thisisdano
approved these changes
Mar 27, 2019
This was referenced Mar 7, 2021
This was referenced Mar 23, 2021
This was referenced Apr 12, 2021
This was referenced Apr 26, 2021
This was referenced May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃槑 Preview
Resolves #2993.
Before
After
Sketch file