Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backward compatible default to $theme-hero-image #3120

Merged
merged 4 commits into from Sep 25, 2019

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Sep 25, 2019

Preview

Hero image theme setting default is now backward compatible: The $theme-hero-image theme variable now has a default equivalent to its effective value pre v2.2.0 so users that had a working version of their hero are more likely to see no issues upgrading to the latest version of USWDS.

  • Although the new default includes a variable reference to $theme-image-path, users can change this to any path needed. It need not refer to $theme-image-path.
  • This new default requires that the component theme variables (uswds-theme-components) be imported after uswds-theme-general. We suggest that uswds-theme-components be the last of the theme variables imported.

Old default:

$theme-hero-image: '..img/hero.png'

New default:

$theme-hero-image: '#{$theme-image-path}/hero.png'

Issue: #3118

@thisisdano thisisdano merged commit e46fea5 into develop Sep 25, 2019
@thisisdano thisisdano deleted the dw-add-bc-hero-var branch September 25, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant