Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Labels] Change ordering of usa-label--{state} classes so they take precedence #3323

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Feb 19, 2020

Description

  • Changed the ordering of the "state" classes for usa-label. This address an issue I ran into where the usa-label--error class wasn't removing the top margin that's added by the usa-label class, even though usa-label--error included margin-top: 0 in its declaration. This seemed due to the ordering of those styles.
  • Removed a redundant display: block property from usa-label--error, which is already applied with the default usa-label class.

Additional information

image

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj
Copy link
Contributor

mejiaj commented Feb 26, 2020

LGTM

@thisisdano thisisdano merged commit ec03e12 into uswds:develop Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants