Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Radio + Checkbox: Fix focus outline on FF. #3918

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Jan 5, 2021

Preview

Radio ➡
Checkbox ➡

Description

Closes #3916.

Additional information

Removes text indent from custom checkbox and radio input. This was causing a wider focus outline than intended on Firefox only.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@thisisdano thisisdano merged commit b7339f0 into develop Jan 5, 2021
@thisisdano thisisdano deleted the jm-ff-input-focus branch January 5, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus outline issue on radio buttons and checkboxes in Firefox browser
2 participants