Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS - Footer: Add instagram social icon #3925 #3948

Merged
merged 2 commits into from
Feb 8, 2021
Merged

USWDS - Footer: Add instagram social icon #3925 #3948

merged 2 commits into from
Feb 8, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Jan 15, 2021 •
edited

Preview links

Description

Created a copy of #3927 from @smustgrave so it can pass through Federalist. Closes #3925

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj mentioned this pull request Jan 15, 2021
Closed
@mejiaj mejiaj added this to Development review in USWDS Sprint Board via automation Jan 15, 2021
@mejiaj mejiaj moved this from Development review to Fed final review in USWDS Sprint Board Jan 15, 2021
@thisisdano thisisdano merged commit efad717 into develop Feb 8, 2021
USWDS Sprint Board automation moved this from Fed final review to Done Feb 8, 2021
@mejiaj mejiaj deleted the mobomo-issue-3925-instagram-social-icon branch February 11, 2021 16:53
This was referenced Feb 19, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

Assignees
No one assigned
Labels
Package: Footer Package: Icons
Projects
USWDS Sprint Board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instagram Social Icon
3 participants
@mejiaj @thisisdano @smustgrave