USWDS - Header: Remove FOUC on extended header with mega-menu. #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
commented
Mar 1, 2021
| @@ -6,9 +6,7 @@ | |||
| } | |||
|
|
|||
| @mixin add-sr-only { | |||
There was a problem hiding this comment.
Seemed like a duplicate of sr-only mixin so I extended it instead.
scottqueen-bixal
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
I followed the testing instructions and did not see that the reported issue from #4047 was still happening.
thisisdano
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4047. Adds a more specific selector to extended header with mega-menu to remove the flash of unstyled content.
Additional information
Steps to test:
Network → No Throttling ↕ → Regular 2GIn Chrome
Network → Online ▼ → Slow 3GBefore you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.