USWDS - Radio Button - radio shows unchecked when disabled even when checked #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ked and disabled. added styles for the --tile version.
mejiaj
previously requested changes
Mar 3, 2021
| <input class="usa-radio__input usa-radio__input--tile" id="historical-marshall-2" type="radio" name="historical-figures" value="thurgood-marshall" disabled checked> | ||
| <label class="usa-radio__label" for="historical-marshall-2">Thurgood Marshall</label> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
Fix indent and remove extra line on 24.
There was a problem hiding this comment.
@jeffffeffff there is still an extra line on line 24
Co-authored-by: James Mejia <s.jamesmejia@gmail.com>
|
@mejiaj Sorry, I dismissed your review, prematurely determining it was stale. Yet it was not! |
4 tasks
|
Closing in favor or more up-to-date PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3979
Description
When a radio input was disabled but also had the checked attribute there was no visual indicator of this combination of states. This PR adds styling to "fill-in" the radio input as if it were checked while also showing other styling indicating it's disabled state. Also adds examples on the radio input component of this :disabled:checked state, including an
.usa-radio__input--tilevariant example.