Avoid unit math on settings until after configured unit resolved

[aduth]

Summary

Attempts to fix #5075 by avoiding math on configurable settings values which could result in an invalid unit token. The effect should be the same, but ensures that the configurable unit value is resolved before attempting any math on it.

Related issue

Fixes #5075

Problem statement

Developers should be able to configure settings to any valid unit and the build should pass.

Solution

Resolves configured unit value before performing math on it.

[mejiaj]

Thank you! I was able to confirm the bug and the fix.

I also looked for other instances where we might be doing math inside of units, but didn't find any.

[amyleadem]

@aduth Thanks for fixing this!
I was able to confirm the issue and that the updates here fix the problem. I also confirmed that there were no visual discrepancies in the affected areas for banner and alert.

I did notice one more instance of calculations happening inside units() in usa-banner: https://github.com/uswds/uswds/blob/develop/packages/usa-banner/src/styles/_usa-banner.scss#L187

Would you be able to update that as well?
Let me know if you have questions. Thanks again!

[aduth]

Hi @amyleadem , in that case is the variable $size-touch-target meant to be configurable by a theme? I was under the impression it's a hard-coded value which wouldn't be prone to the same sorts of conflicts.

uswds/packages/uswds-core/src/styles/variables/size-touch-target.scss

Line 1 in e75f3f3

$size-touch-target: 6; // 48px to meet WCAG minimum of 44px

That being said, even if it's not configurable, I could see it being helpful to update it anyways for consistency. I'll push those changes shortly.

[aduth]

Updated the banner unit math in 3d830f7 .

[amyleadem]

Thanks for the quick response on this @aduth! Looks good to me.

[thisisdano]

Thank you!