USWDS - Dependencies: Update gulp-mocha to resolve nanoid issue. #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
commented
Dec 15, 2023
| @@ -142,7 +142,7 @@ | |||
| "gulp-changed": "4.0.3", | |||
| "gulp-clean": "0.4.0", | |||
| "gulp-cli": "2.3.0", | |||
| "gulp-mocha": "8.0.0", | |||
There was a problem hiding this comment.
Important
This is the latest version that supports CommonJS. v10 only supports ESM. See gulp-mocha releases on GitHub for more information.
mejiaj
changed the title
mahoneycm
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Looks great! Thanks!
Testing checklist
- Confirmed
nanoidvulnerability ondevelop - Feature branch has fewer vulnerabilities
-
nanoidvulnerability is resolved -
npm testruns without errors - Confirmed this is the latest version of
gulp-mochathat can use CommonJS
Note
I updated the description of this vulnerability on the POAM Spreadsheet 🔒 but I did not mark as resolved. We should mark the listing as resolved once merged 👍
amyleadem
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Looks good! I ran the following tests:
- Confirm the
nanoidwarning is removed after runningnpm audit- Before: 51 vulnerabilities (24 moderate, 27 high)
- After: 48 vulnerabilities (23 moderate, 25 high)
- Run
npm installwithout error - Run
npm startwithout error - Run
npm run testwithout error - Run
gulpcommands without error
5 tasks
thisisdano
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update unit testing dependency for improved security. Update
gulp-mochato major version 9 to resolve a sub-dependency issue.Breaking change
This is not a breaking change.
Related issue
Closes #5674.
Related pull requests
N/A
Preview link
StorybookJS preview link
Problem statement
Gulp mocha needs to be updated to a major version to resolve issue with sub-dependency.
Solution
Upgraded to major version 9, which is the latest version we can upgrade to without major LOE changes.
Dependency updates
gulp-mochaThis is the latest version we can upgrade to. v10 has major breaking changes with ESM support only.
How to test
developrunnpm install && npm audit.nanoiddependency.npm install && npm audit.Testing checklist
nanoidissue anymore.Before: 51 vulnerabilities (24 moderate, 27 high).
After: 48 vulnerabilities (23 moderate, 25 high).
As of 12/15/23