Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - POAM: May '24 #5924

Merged
merged 3 commits into from
May 28, 2024
Merged

USWDS - POAM: May '24 #5924

merged 3 commits into from
May 28, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented May 10, 2024

Changelog PR

Title

USWDS - POAM: May ‘24

Summary

POAM updates for May 2024

Important

This work should be merged after the April POAM updates #5854

Breaking change

This is not a breaking change.

Preview link

Preview link →

Major changes

Minor and patch updates to direct dependencies

41 vulnerabilities (13 moderate, 28 high)

Testing and review

  1. Run npm install and confirm there are no errors
  2. Run npm start.
  3. Update a SASS file and see it update in StorybookJS.
  4. Running npx gulp sassTests or npm run test should not fail.
  5. Run gulp tasks (like build) and ensure there aren't errors and things build correctly
  6. Installing on site does not cause any installation or build errors

Dependency updates

Dependency name Previous version New version
@babel/core 7.24.4 7.24.5
@babel/preset-env 7.24.4 7.24.5
@types/node 20.12.5 20.12.11
axe-core 4.9.0 4.9.1
post-css-preset-env 9.5.4 9.5.11
sass 1.74.1 1.77.0
sass-embedded 1.74.1 1.77.0
snyk 1.1287.0 1.1291.0
svgo 3.2.0 3.3.2
typescript 5.4.4 5.4.5

@mahoneycm mahoneycm mentioned this pull request May 10, 2024
6 tasks
@mahoneycm mahoneycm changed the base branch from cm-POAM-april-2024 to develop May 14, 2024 14:24
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update once #5854 and #5782 are merged.

@mahoneycm mahoneycm marked this pull request as ready for review May 24, 2024 14:05
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before [develop]

43 vulnerabilities (13 moderate, 30 high)

After

41 vulnerabilities (13 moderate, 28 high)

Did a quick check on styles in storybook and I don't see any visual regressions either.

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Ran npm install, npm run start, npm run build, and npm run test without error
  • Updated styles and confirmed they were reflected in storybook
  • Confirmed the dependency list in the PR description matches the changed dependencies.

@mahoneycm mahoneycm requested a review from thisisdano May 24, 2024 15:17
@thisisdano thisisdano merged commit 2f73c46 into develop May 28, 2024
5 checks passed
@thisisdano thisisdano deleted the cm-POAM-may-2024 branch May 28, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants