self host helm chart #232
self host helm chart #232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=====================================
Coverage 42% 42%
=====================================
Files 25 25
Lines 900 900
=====================================
Hits 378 378
Misses 486 486
Partials 36 36 |
|
so it seems that it does not like being hosted in s3 Strangely it works if you do a full path |
|
so that is because inside index.yaml you get |
|
seems like there is a PR on helm-s3 to fix this hypnoglow/helm-s3#70 but it's not been merged, the alternative is to use github pages but that will require more work to implement |
| {{- end }} | ||
| - name: xtables | ||
| hostPath: | ||
| path: /run/xtables.lock |
There was a problem hiding this comment.
Please add type: FileOrCreate to match https://github.com/uswitch/kiam/blob/master/deploy/agent.yaml#L32 and address helm/charts#9261
| - name: {{ template "kiam.name" . }}-{{ .Values.agent.name }} | ||
| {{- if .Values.agent.host.iptables }} | ||
| securityContext: | ||
| privileged: true |
There was a problem hiding this comment.
Please only add NET_ADMIN capability to match https://github.com/uswitch/kiam/blob/master/deploy/agent.yaml#L37 and improve security of the agent
| - name: tls | ||
| secret: | ||
| {{- if .Values.server.tlsSecret }} | ||
| secretName: {{ .Values.server.tlsSecret }} |
There was a problem hiding this comment.
Consider adding optional: false, it should prevent creation of the container when the secret is not mounted.
| {{- if .Values.server.tlsSecret }} | ||
| secretName: {{ .Values.server.tlsSecret }} | ||
| {{else}} | ||
| secretName: {{ template "kiam.fullname" . }}-server |
There was a problem hiding this comment.
Consider adding optional: false, it should prevent creation of the container when the secret is not mounted.
| - name: tls | ||
| secret: | ||
| {{- if .Values.agent.tlsSecret }} | ||
| secretName: {{ .Values.agent.tlsSecret }} |
There was a problem hiding this comment.
Consider adding optional: false, it should prevent creation of the container when the secret is not mounted.
| {{- if .Values.agent.tlsSecret }} | ||
| secretName: {{ .Values.agent.tlsSecret }} | ||
| {{else}} | ||
| secretName: {{ template "kiam.fullname" . }}-agent |
There was a problem hiding this comment.
Consider adding optional: false, it should prevent creation of the container when the secret is not mounted.
|
I'm happy to be replaced in the maintainers list in |
|
@Joseph-Irving would you mind if I contribute my suggestions to your branch? |
|
@danmx, sorry not really looked at this as the self hosting does not currently work. I'd rather get the hosting working first and then look at adding your suggestions. |
It seems that project is not maintained anymore |
|
why not use |
In relation to #230
To make it easier for people to contribute to the kiam helm chart we can keep the definition here and self host the repo.
I've just set up an s3 bucket to use for this purpose. https://s3-eu-west-1.amazonaws.com/kiam-helm/charts