Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded button height - was causing bugs #454

Merged
merged 3 commits into from May 12, 2020
Merged

Remove hardcoded button height - was causing bugs #454

merged 3 commits into from May 12, 2020

Conversation

callumacrae
Copy link
Contributor

@callumacrae callumacrae commented May 12, 2020 •
edited

  • With one line of text, the button height was slightly too small
  • Buttons couldn't have more than one line of text

https://app.asana.com/0/1153286245702289/1175415548003665

image

image

Checklist

Pull request contains:

  • A new component
  • Component maintenance: improvement / bug fix / etc
  • Component library change: storybook / webpack / etc

Definition of done:

  • Includes theme changes for both Uswitch and money
  • Work has been tested in multiple browsers
  • PR description includes description of change
  • PR description includes screenshot of change
  • If new component, designer has approved screenshot
  • If the change will affect other teams, that team knows about this change
  • If introducing a new component behaviour, added a story to cover that case.
  • If component change, version updated

@callumacrae
Remove hardcoded button height - was causing bugs
5565168 
- With one line of text, the button height was slightly too small
- Buttons couldn't have more than one line of text
Segger87
Segger87 previously approved these changes May 12, 2020
View reviewed changes
@callumacrae
Copy link
Contributor Author

blocked by #451 release

@callumacrae
Merge remote-tracking branch 'origin/master' into button-heights
2f2d795
@callumacrae
Publish
bb4afc2 
 - @uswitch/trustyle.button@1.0.0
 - @uswitch/trustyle.bankrate-theme@0.2.7
 - @uswitch/trustyle.money-theme@0.11.9
@callumacrae callumacrae merged commit 9daa919 into master May 12, 2020
@callumacrae callumacrae deleted the button-heights branch May 12, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Segger87 Segger87 Segger87 approved these changes

@jonathan-fielding jonathan-fielding jonathan-fielding left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@callumacrae @jonathan-fielding @Segger87