Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go mod for dependency management #45

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Switch to go mod for dependency management #45

merged 3 commits into from
Sep 2, 2019

Conversation

rhysemmas
Copy link
Contributor

No description provided.

Copy link

@realdimas realdimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also drop /vendor as a separate commit as part of the same PR?

@DewaldV
Copy link
Member

DewaldV commented Sep 2, 2019

Was going to ask if we should update the vendor dir or drop it. :)

.drone.yml Outdated
@@ -4,12 +4,16 @@ workspace:

pipeline:
test:
image: golang:1.10
image: golang:1.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just go to 1.12

Joseph-Irving
Joseph-Irving previously approved these changes Sep 2, 2019
realdimas
realdimas previously approved these changes Sep 2, 2019
@rhysemmas rhysemmas merged commit 603485b into master Sep 2, 2019
@rhysemmas rhysemmas deleted the use-go-mod branch September 2, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants