Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DOWNLOAD_EXTRACT_TIMESTAMP option to ExternalProject_Add() #202

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Set DOWNLOAD_EXTRACT_TIMESTAMP option to ExternalProject_Add() #202

merged 1 commit into from
Sep 5, 2022

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented Sep 5, 2022 •
edited
Loading

Overview

From CMake 3.24, CMP0135 policy was introduced.
So, it will be required to explicitly specify DOWNLOAD_EXTRACT_TIMESTAMP option when using the URL download method with the ExternalProject_Add().

Issue

  • N/A

Details

  • CMP0135
  • Resolve CMake warning in build ExtLibraries/cspice

Validation results

Remove CMake dev warning on CI.

Scope of influence

ExtLibraries CMake update(No behaviour change)

Supplement

Write additional comments if you need.

Note

  • If there are related Projects, tie them together.
  • Assignees should be set if possible.
  • Reviewers should be set if possible.
  • Set priority label if possible.

@sksat sksat added priority::low priority low tools labels Sep 5, 2022
@sksat sksat self-assigned this Sep 5, 2022
@sksat sksat force-pushed the feature/cmake-download-extract-timestamp branch from b00d989 to e2d7217 Compare September 5, 2022 09:22
@sksat sksat force-pushed the feature/cmake-download-extract-timestamp branch from e2d7217 to 7f7ede8 Compare September 5, 2022 09:24
meltingrabbit
meltingrabbit approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こんなのあるんだね．

@sksat
Copy link
Collaborator Author

sksat commented Sep 5, 2022

かなり最近生えたやつですね

@sksat sksat merged commit df3562a into develop Sep 5, 2022
@sksat sksat deleted the feature/cmake-download-extract-timestamp branch September 5, 2022 10:03
@sksat sksat mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@sksat sksat

Labels
priority::low priority low tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sksat @meltingrabbit