Fix comments in Simulation
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200km
added
documentation
|
@sksat @seki-hiro 新しい学生が開発に加わる前に、実行に影響を与えない範囲で読みやすくするため、コメントを修正し始めました。方針に問題ないかなどクイックにコメントいただけると嬉しいです |
|
方針に問題ないと思います．細かい修正もありがとうございます． |
|
方針に問題ないと思います．一部日本語の雑なコメントを単に消している部分は，もう古くなってしまっている情報ということですかね？ |
|
コメントありがとうございます。この方針で進めます。
そうですね。今見て意図がいまいちわからないコメントは消してしまっています。あとは、そのファイルが実質使われていないというのもあったりします。(S2E_parallelなど) |
|
了解です．ではよさそう． |
|
@seki-hiro @sksat WIPはずしたのでレビューをお願いします。 |
seki-hiro
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix comments in
SimulationIssue
Details
Fix comments in
SimulationValidation results
NA
Scope of influence
No effect on execution
Supplement
NA
Note
NA