Refactor simulation #338
Merged
Refactor simulation #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This was referenced Mar 7, 2023
Merged
suzuki-toshihir0
approved these changes
Mar 11, 2023
| * @brief Set ordered torque in the body fixed frame [Nm] | ||
| */ | ||
| inline void SetTorque_b_Nm(const libra::Vector<3> torque_b_Nm) { ordered_torque_b_Nm_ = torque_b_Nm; }; | ||
| inline void SetTorque_b_Nm_Nm(const libra::Vector<3> torque_b_Nm) { ordered_torque_b_Nm_ = torque_b_Nm; }; |
There was a problem hiding this comment.
Suggested change
| inline void SetTorque_b_Nm_Nm(const libra::Vector<3> torque_b_Nm) { ordered_torque_b_Nm_ = torque_b_Nm; }; | |
| inline void SetTorque_b_Nm(const libra::Vector<3> torque_b_Nm) { ordered_torque_b_Nm_ = torque_b_Nm; }; |
[NITS] typo
| magtorquer_conf.ReadVector(MTSection, "min_output_magnetic_moment_c_Am2", min_magnetic_moment_c_Am2); | ||
|
|
||
| Vector<kMtqDimension> bias_noise_c_Am2_; | ||
| libra::Vector<kMtqDimension> bias_noise_c_Am2_; |
There was a problem hiding this comment.
Suggested change
| libra::Vector<kMtqDimension> bias_noise_c_Am2_; | |
| libra::Vector<kMtqDimension> bias_noise_c_Am2; |
[NITS] 末尾の _ が不要ですね．
| @@ -198,9 +198,9 @@ std::string StarSensor::GetLogValue() const { | |||
| } | |||
|
|
|||
| double StarSensor::CalAngleVector_rad(const Vector<3>& vector1, const Vector<3>& vector2) { | |||
| Vector<3> vect1_normal(vector1); | |||
| libra::Vector<3> vect1_normal(vector1); | |||
There was a problem hiding this comment.
[NITS] vect1 -> vector1 などに修正したいです．
src/simulation/case/sample_case.cpp
Outdated
| if (glo_env_->GetSimulationTime().GetState().disp_output) { | ||
| cout << "Progresss: " << glo_env_->GetSimulationTime().GetProgressionRate() << "%\r"; | ||
| if (global_environment_->GetSimulationTime().GetState().disp_output) { | ||
| cout << "Progresss: " << global_environment_->GetSimulationTime().GetProgressionRate() << "%\r"; |
There was a problem hiding this comment.
Suggested change
| cout << "Progresss: " << global_environment_->GetSimulationTime().GetProgressionRate() << "%\r"; | |
| cout << "Progress: " << global_environment_->GetSimulationTime().GetProgressionRate() << "%\r"; |
[NITS] typo
| auto newparam = new InitParameter(); | ||
| newparam->SetRandomConfig(mean_or_min, sigma_or_max, rnd_type); | ||
| ip_list_[name] = newparam; | ||
| auto newparam = new InitializedMonteCarloParameters(); |
There was a problem hiding this comment.
Suggested change
| auto newparam = new InitializedMonteCarloParameters(); | |
| auto new_parameters = new InitializedMonteCarloParameters(); |
[IMO] 書き下したいです．
There was a problem hiding this comment.
他もそうですが、scopeが小さくて外に影響のない関数内の変数名などをすべて修正するのは今回諦めており、指摘してくれている以外の部分もたくさん残っています。(coding rule 的にもそのような記述を入れています)
major updateにはならないpatchレベルのものなので今回は未対応で進めて、major update後に取り組んで行こうと思い舞うs。
There was a problem hiding this comment.
承知しました。あまり細かく見過ぎてテンポが悪くなっても仕方ないので気付いたものくらいはコメントしよう……くらいの感覚でした。major update以降のご対応で大丈夫です。
Base automatically changed from
feature/refactor-components
to
feature/major-update-v6.0.0
March 12, 2023 07:08
…core into feature/refactor-simulation
|
ご指摘いただいたtypo等は修正し、approveももらっているのでマージします。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor simulation
Issue
Details
Refactor simulation directory
Validation results
See CI
Scope of influence
NA
Supplement
NA
Note
Review and Merge after #337