Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simulation_sample directory #372

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Mar 23, 2023

Overview

Make simulation_sample directory

Issue

  • NA

Details

I made simulation_sample directory to store sample codes.

Validation results

See CI

Scope of influence

NA

Supplement

NA

Note

NA

@200km 200km added priority::high priorityg high simulation simulation settings major update incompatible API changes labels Mar 23, 2023
@200km 200km added this to the Major update for v6.0.0 milestone Mar 23, 2023
@200km 200km added this to In progress in S2E via automation Mar 23, 2023
@200km 200km self-assigned this Mar 23, 2023
Copy link
Member

@suzuki-toshihir0 suzuki-toshihir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい点だけコメントしていますが,変更内容に問題ないと思いますのでapproveします.

@@ -34,4 +35,4 @@ class SampleSpacecraft : public Spacecraft {
SampleComponents* sample_components_;
};

#endif // S2E_SIMULATION_SPACECRAFT_SAMPLE_SPACECRAFT_SAMPLE_SPACECRAFT_HPP_
#endif // SS2E_SIMULATION_SAMPLE_SPACECRAFT_SAMPLE_SPACECRAFT_HPP_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#endif // SS2E_SIMULATION_SAMPLE_SPACECRAFT_SAMPLE_SPACECRAFT_HPP_
#endif // S2E_SIMULATION_SAMPLE_SPACECRAFT_SAMPLE_SPACECRAFT_HPP_

[NITS] typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。修正したのでマージします。

Base automatically changed from feature/refactor-simulation-for-easy-use to feature/major-update-v6.0.0 March 24, 2023 04:28
@200km 200km merged commit 6a316d3 into feature/major-update-v6.0.0 Mar 24, 2023
S2E automation moved this from In progress to Done Mar 24, 2023
@200km 200km deleted the feature/make-sample-directory branch March 24, 2023 04:48
@200km 200km mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major update incompatible API changes priority::high priorityg high simulation simulation settings
Projects
No open projects
S2E
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants