Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CI with GitHub Actions(windows runner) #39

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented Jan 24, 2022

Overview

  • Add CMake for build ../ExtLibraries
    • support windows only(currently)
  • Add build CI with GitHub Actions windows runner

Issue

Details

  • ExtLibraries/CMakeLists.txt download & build external dependencies and install to ../ExtLibraries

Validation results

Scope of influence

N/A

Supplement

  • ../ExtLibraries will be controlled by ExtLibraries/CMakeLists.txt(not on this PR)

Note

  • If there are related Projects, tie them together.
  • Assignees should be set if possible.
  • Reviewers should be set if possible.
  • Set priority label if possible.

@sksat sksat added the enhancement New feature or request label Jan 24, 2022
@sksat sksat self-assigned this Jan 24, 2022
Copy link
Contributor

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ざっと理解したので,良さそうです.

一応 @200km の確認待ってからマージしたほうが良さそうね.

Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思います。

@sksat
Copy link
Collaborator Author

sksat commented Jan 24, 2022

確認ありがとうございます.マージします.

@sksat sksat merged commit 79120fb into develop Jan 24, 2022
@sksat sksat deleted the feature/build-ci branch January 24, 2022 12:28
@sksat sksat mentioned this pull request Jan 26, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants