Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to easily provide custom scales #29

Closed
6 tasks done
oubiwann opened this issue Aug 28, 2021 · 0 comments
Closed
6 tasks done

Allow users to easily provide custom scales #29

oubiwann opened this issue Aug 28, 2021 · 0 comments
Milestone

Comments

@oubiwann
Copy link
Contributor

oubiwann commented Aug 28, 2021

Right now, um:scales performs a lookup in the undertheory scales module. We should let users provide their own sequence of notes (in the form of, e.g., (1 3 |#4| 5 b7), etc.). To do things, we'll need to readjust some things and create some new functions:

  • rename midi to pitches
  • rename get to create
  • add a guard to pitches
    • if scale is an atom, convert
    • if scale is a list, don't do a lookup
  • update create to use new pitches

This need has arisen as a result of investigating implementation ideas for #16 -- chords are much more varied than scales and definitions are not consistent, so users will need to provide their own notes/forms even more there, than here with scales.

That being said, the majority of the logic will be shared between the two. So this change should take that info consideration:

  • what functionality will be shared?
  • move that out of um:scales and into um (or wherever else makes sense)
  • adjust um:scales as necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant