Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double click does not open test package #124

Closed
PhilippSalvisberg opened this issue Jan 4, 2021 · 0 comments · Fixed by #129
Closed

Double click does not open test package #124

PhilippSalvisberg opened this issue Jan 4, 2021 · 0 comments · Fixed by #129
Assignees
@PhilippSalvisberg
Labels
bug
Milestone
v1.3.1

Comments

@PhilippSalvisberg
Copy link
Member

A double click in the table view opens the test package specification at the starting line of the test procedure for successful tests. For tests with failure the test package body is opened at the line of the first failed assert.

In the tree-table view no actions are configured for a double-click. The following is expected:

Find the first test in the tree and do the same as in the tree-table view:

  • tests with failures: open package body at the line of the first failed assert
  • in all other cases: open package spec at the line of the test declaration
@PhilippSalvisberg PhilippSalvisberg self-assigned this Jan 4, 2021
@PhilippSalvisberg PhilippSalvisberg added this to the v1.3.1 milestone Jan 4, 2021
PhilippSalvisberg added a commit that referenced this issue Jan 4, 2021
@PhilippSalvisberg
fixes #124 handles double-click event on tree-table view
77f9f0b 
open package body at the position of the first failed assert when a test is selected.
open the package spec at the position of test declaration when a test is selected.
open the package spec at line 1 if a the node contains only one package.
@PhilippSalvisberg PhilippSalvisberg mentioned this issue Jan 4, 2021
Merged
PhilippSalvisberg added a commit that referenced this issue Jan 4, 2021
@PhilippSalvisberg
Merge pull request #129 from utPLSQL/bugfix/issue-124-double-click-on…
6df7d05 
…-tree-node

Bugfix #124 (double click on tree node) and #118 (special characters in connection name)
PhilippSalvisberg added a commit that referenced this issue Jan 4, 2021
@PhilippSalvisberg
add test for to reproduce issue #124
0c7b0c8
PhilippSalvisberg added a commit that referenced this issue Jan 4, 2021
@PhilippSalvisberg
exclude nested elements in XMLtools.getElementNode
b325a70 
This ensures that the description of a child suite is not used for a parent suite when the parent suite does not have a description. This was the root cause of issue #124.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippSalvisberg PhilippSalvisberg

Labels
bug
Projects
None yet
Milestone
v1.3.1
1 participant
@PhilippSalvisberg