Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for test runs over 4 hours #1243

Merged
merged 6 commits into from Feb 11, 2023
Merged

Allow for test runs over 4 hours #1243

merged 6 commits into from Feb 11, 2023

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Feb 8, 2023

Resolves #1242

Refactored output buffers to have better segregation of responsibilities.

Changed behavior of output buffers get_lines procedure to stop immediately after consuming all produced data if producer has stopped.
Changed behavior of output buffers get_lines procedure not to timeout after 4 hours, if producer is still running.

…ies.

Changed behavior of output buffer `get_lines` procedure to stop immediately after consuming all produced data if producer has stopped.
Changed behavior of output buffer `get_lines` procedure not to timeout after 4 hours, if producer is still running.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Unit Test Results

       1 files         2 suites   5m 21s ⏱️
1 027 tests 1 023 ✔️ 4 💤 0
1 030 runs  1 022 ✔️ 8 💤 0

Results for commit 865785a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 95.13% // Head: 94.84% // Decreases project coverage by -0.29% ⚠️

Coverage data is based on head (865785a) compared to base (315e5c6).
Patch coverage: 91.08% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1243      +/-   ##
===========================================
- Coverage    95.13%   94.84%   -0.29%     
===========================================
  Files          108      108              
  Lines         5093     5105      +12     
  Branches        22       23       +1     
===========================================
- Hits          4845     4842       -3     
- Misses         240      255      +15     
  Partials         8        8              
Flag Coverage Δ
11XE 94.27% <90.90%> (-0.24%) ⬇️
12.1EE 94.20% <90.90%> (-0.28%) ⬇️
18XE 94.48% <90.09%> (-0.31%) ⬇️
21XE 94.66% <90.09%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/core/coverage/ut_coverage_reporter_base.tpb 100.00% <ø> (ø)
...urce/core/output_buffers/ut_output_buffer_base.tpb 76.78% <77.14%> (-23.22%) ⬇️
...rce/core/output_buffers/ut_output_table_buffer.tpb 83.33% <97.14%> (-3.11%) ⬇️
...ore/output_buffers/ut_output_clob_table_buffer.tpb 95.74% <100.00%> (-2.51%) ⬇️
source/core/types/ut_output_reporter_base.tpb 78.94% <100.00%> (-1.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.2% 94.2% Coverage
0.0% 0.0% Duplication

@jgebal jgebal marked this pull request as ready for review February 11, 2023 10:48
@jgebal jgebal merged commit 5cf7f34 into develop Feb 11, 2023
@jgebal jgebal deleted the feature/output_buffer_sync branch February 11, 2023 10:48
@jgebal jgebal added this to the v3.1.14 milestone May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout after 4 hours on reporter waiting for data
1 participant