Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex to be NLS_SORT independent #1253

Merged
merged 1 commit into from May 27, 2023
Merged

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented May 21, 2023

Resolves #1252
Replaced all regexp ranges with posix representations to avoid NLS_SORT impact on regex behavior.

Replaced all regexp ranges with posix representations to avoid NLS_SORT impact on regex behavior.
@jgebal jgebal added this to the v3.1.14 milestone May 21, 2023
@jgebal jgebal requested a review from lwasylow May 21, 2023 09:56
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2023

Unit Test Results

       1 files         2 suites   5m 5s ⏱️
1 049 tests 1 045 ✔️ 4 💤 0
1 053 runs  1 045 ✔️ 8 💤 0

Results for commit 962f6fd.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (320b3b0) 94.67% compared to head (962f6fd) 94.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1253      +/-   ##
===========================================
+ Coverage    94.67%   94.69%   +0.01%     
===========================================
  Files          111      111              
  Lines         5374     5374              
  Branches        33       33              
===========================================
+ Hits          5088     5089       +1     
  Misses         278      278              
+ Partials         8        7       -1     
Flag Coverage Δ
11XE 94.27% <80.00%> (ø)
12.1EE 94.33% <80.00%> (+0.05%) ⬆️
18XE 94.50% <100.00%> (ø)
21XE 94.67% <100.00%> (ø)
23free 94.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/core/ut_metadata.pkb 89.88% <ø> (ø)
source/core/annotations/ut_annotation_manager.pkb 98.91% <100.00%> (ø)
source/core/annotations/ut_annotation_parser.pkb 95.94% <100.00%> (ø)
source/core/types/ut_executable_test.tpb 94.28% <100.00%> (ø)
source/core/ut_expectation_processor.pkb 100.00% <100.00%> (ø)
source/core/ut_suite_cache_manager.pkb 97.01% <100.00%> (ø)
source/core/ut_suite_manager.pkb 96.29% <100.00%> (ø)
source/core/ut_utils.pkb 94.74% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented May 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jgebal jgebal merged commit 020150f into develop May 27, 2023
21 checks passed
@jgebal jgebal deleted the bugfix/regex_fail_on_nls_sort branch May 27, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The functionality of utPLSQL is dependent on the session parameter NLS_SORT
1 participant