Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganized test-users privileges #950

Merged
merged 3 commits into from Jun 21, 2019
Merged

Reorganized test-users privileges #950

merged 3 commits into from Jun 21, 2019

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Jun 20, 2019

No description provided.

@jgebal
Reorganized test-users privileges
8620240
@jgebal
Added back grant administer database trigger to &&ut3_owner;
b21dbaa 
This is only needed for the duration of the install process.
We also re-enable this privilege to allow for tests to disable/enable trigger.
@jgebal jgebal added this to the v3.1.8 milestone Jun 20, 2019
@jgebal jgebal changed the title Feature/fix privs for dbms crypto Reorganized test-users privileges Jun 20, 2019
@jgebal jgebal marked this pull request as ready for review June 20, 2019 00:22
@lwasylow
Copy link
Member

lwasylow commented Jun 20, 2019 •
edited

Since you working already in install I've noticed that uninstall got some error:

In command -
drop trigger ut_trigger_annotation_parsing
Error report -
ORA-04080: trigger 'UT_TRIGGER_ANNOTATION_PARSING' does not exist

Is that expected?

@jgebal
Copy link
Member Author

jgebal commented Jun 20, 2019

@lwasylow - is this on Travos or local error?
If local, did you install wirh trigger?

@lwasylow
Copy link
Member

It's on Travis

@jgebal
Copy link
Member Author

jgebal commented Jun 20, 2019

Odd.
Looking into Travis logs I see the trigger is getting dropped successfully.
https://travis-ci.org/utPLSQL/utPLSQL/jobs/547976502#L2275
https://travis-ci.org/utPLSQL/utPLSQL/jobs/547960863#L2270

The only thing that is not getting dropped cleanly is a synonym (as it doesn't exist at that time yet)

@lwasylow
Copy link
Member

Line 2714 of log https://travis-ci.org/utPLSQL/utPLSQL/jobs/547976502
Error starting at line : 177 File @ /home/travis/build/utPLSQL/utPLSQL/source/uninstall_objects.sql
In command -
drop trigger ut_trigger_annotation_parsing
Error report -
ORA-04080: trigger 'UT_TRIGGER_ANNOTATION_PARSING' does not exist

@jgebal
Copy link
Member Author

jgebal commented Jun 21, 2019

@lwasylow - this one is resolved now - the drop trigger was there twice in uninstall script.
Maybe we should make uninstall fail on any error in Travis just to make sure it always works without issues.

@lwasylow
Copy link
Member

Yes agree, it should fail in build env.

@jgebal
Copy link
Member Author

jgebal commented Jun 21, 2019

This is done as part of #953
So I'm merging this PR.

@jgebal jgebal merged commit fdbc3b4 into develop Jun 21, 2019
@jgebal jgebal deleted the feature/fix_privs_for_dbms_crypto branch November 10, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwasylow lwasylow lwasylow approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3.1.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jgebal @lwasylow