Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Details and Information #353

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Addition of Details and Information #353

merged 1 commit into from
Oct 14, 2022

Conversation

KomashiFX
Copy link
Contributor

  • In Brazil TicTacToe is called Jogo da Velha, so i put on description with translation to make more easier to understand
  • I changed some texts that almost went out of sense < This was difficult to write so I used the translator

@KomashiFX
Addition of Details and Information
7fb8d2b 
- In **Brazil** TicTacToe is called **Jogo da Velha**, so i put on description with translation to make more easier to understand
- I changed some texts that almost went out of sense `< This was difficult to write so I used the translator`
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KomashiFX
Copy link
Contributor Author

note: i changed VS to CONTRA because is more used here.

utarwyn
utarwyn approved these changes Oct 14, 2022
View reviewed changes
Copy link
Owner

@utarwyn utarwyn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for this contribution! As I am a native French speaker, I cannot verify proposed translations with a good accuracy.. and I trust contributors on languages that I don't know enough about.

LGTM 💯

@utarwyn utarwyn merged commit b8969bc into utarwyn:next Oct 14, 2022
@KomashiFX KomashiFX deleted the patch-1 branch October 14, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KomashiFX @utarwyn