-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to select library or executable #22
Allow user to select library or executable #22
Conversation
Thank you!
I personally use this more often for libraries, however even when I am writing an executable I also have an internal library doing most of the stuff, and a very thin executable section mostly for invoking the library. The main reason is to be able to import the library from the For the same reason, I have a slight preference for formulating the question more like "do you need an I think it would also be good to have another test for this functionality too. Ideally, we'd test every combination of options ( |
Yeah, I like the former as well. Another option, maybe, would be to add a commented executable section to *.cabal, package.yaml just so it is easy to include one if you want. I agree that most of the time I am opening up the library section first. |
But then, would we still include the main module (and possibly a separate directory)? That doesn't sound ideal to me, I think your approach on this PR is better. If you change the prompt to something along the lines of "include executable section/stanza/module" (feel free to pick a better wording) instead of "library or executable", and add some test cases, I'm happy with this PR merged :). If you don't have time, I'd be happy to work on this too, just let me know :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few cosmetic comments :).
Co-authored-by: Utku Demir <me@utdemir.com>
Co-authored-by: Utku Demir <me@utdemir.com>
20a9677
to
0bcc466
Compare
The multiline string thing doesn't appear to work. I have no clue how to get it to pass CI. I think I'll revert that for now and submit an issue |
Updated! I think this will be a nice ergo boost for users! |
This is great, thanks! |
Closes #18
The only real question is do we expect more libraries than executables? I think the answer is yes but maybe you have an opinion