This repository has been archived by the owner on Apr 1, 2023. It is now read-only.
Test inlining #12
Merged
Test inlining #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2013 11:46
|
Useful feature, thanks! |
|
Thanks! |
axos88
pushed a commit
to axos88/sidekiq-status
that referenced
this pull request
Jun 7, 2022
…precation-warnings Fix redis deprecation warnings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drawing analogy from sidekiq testing by inlining,
sidekiq-statusallows to bypass redis and return a stubbed:completestatus.Since inlining your sidekiq worker will run it in-process, any exception it throws will make your test fail.
It will also run synchronously, so by the time you get to query the job status, the job will have been completed
successfully.
In other words, you'll get the
:completestatus only if the job didn't fail.Inlining example:
You can run Sidekiq workers inline in your tests by requiring the
sidekiq/testing/inlinefile in your{test,spec}_helper.rb:require 'sidekiq/testing/inline'To use
sidekiq-statusinlining, require it too in your{test,spec}_helper.rb:require 'sidekiq-status/testing/inline'