Controller Bug Fixes #212
Merged
Controller Bug Fixes #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove many warnings.
|
Needs testing before merge. |
|
Tested to work in offline runs path between 5 and 500 vertices long. No seg faults any more. |
|
Tested with extremely short path and long path on Warthog. |
SvenLilge
approved these changes
May 1, 2024
SvenLilge
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes:
Hopefully, solve the CBIT crash on spline interpolation when the repeat path is less than five vertices long. (Close #201)
Use min speed parameter in the speed scheduler. Was using hard-coded 0.5 m.s
Warnings Reductions:
Change many
inttosize_tin for loops.Remove some unused parameters
Start migrating namespaces to match conventions.