lsfd: (tests) fix process leak #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-8ch
reviewed
May 20, 2023
tests/ts/lsfd/option-inet
Outdated
| wait "${PID2}" | ||
| for pid in "${PID0}" "${PID1}" "${PID2}" "${PID3}" "${PID4}"; do | ||
| kill -CONT "${pid}" | ||
| wait "${pid}" |
There was a problem hiding this comment.
Couldn't this be simplified to:
kill -CONT "${PID0}" "${PID1}" "${PID2}" "${PID3}" "${PID4}"
wait "${PID0}" "${PID1}" "${PID2}" "${PID3}" "${PID4}"
It would be a bit faster and easier to read, IMO.
There was a problem hiding this comment.
Looks better. I'll update. Thank you.
masatake
force-pushed
the
test--fix-process-leak
branch
from
88b2f25
to
22bc846
Compare
t-8ch
approved these changes
May 20, 2023
|
@masatake FYI the util-linux list is available on lore.kernel.org which is nicer to use than marc.info: https://lore.kernel.org/util-linux/652d32c5-4b33-ce3a-3de7-9ebc064bbdcb@gmail.com/ |
Unifying multiple invocations of kill command and wait command into two is suggested by Thomas Weißschuh <thomas@t-8ch.de>. Addresses: https://lore.kernel.org/util-linux/652d32c5-4b33-ce3a-3de7-9ebc064bbdcb@gmail.com/ Reported-by: Bruce Dubbs <bruce.dubbs@gmail.com> Tested-by: Bruce Dubbs <bruce.dubbs@gmail.com> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
test--fix-process-leak
branch
from
22bc846
to
4703571
Compare
|
@t-8ch, thank you for the tip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported-by: Bruce Dubbs bruce.dubbs@gmail.com
ref. https://marc.info/?l=linux-kernel&m=168445262924692&w=2