fixes for sysfs devchain logic #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make sense to leave the sysfs hierarchy during the walk of the parent directories. Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
|
I guess it would make sense to have some sort of utility to get a string from a buffer. |
If I good remember, it's always zero-terminated in the buffer, but ul_buffer_get_data() does not count the terminator. Anyway, ul_buffer_get_string() sounds good, send patch ;-) |
Some users need a zero-byte-terminated string. As the buffer internally already maintains a zero-termination, add a helper function that exposes this to users. Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
sysfs_blkdev_get_devchain() does not zero-terminate its result, but the caller expects a C-string. Use ul_buffer_get_string() which includes a trailing zero-byte. Now it's also valid for sz and bufsz to be equal. See util-linux#3088. Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in the commit messages.