Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unmounting FUSE mounts #705

Closed
wants to merge 2 commits into from
Closed

Support unmounting FUSE mounts #705

wants to merge 2 commits into from

Commits on Oct 14, 2018

  1. Do restricted canonicalize in a subprocess 

    Accessing FUSE mounts require suid/sgid (saved uid) to be equal to the
owner of the mount. If mount is running as a setuid process, swapping
creds by only setting the euid/egid isn't enough to change the
suid/sgid as well. We must do a full setuid()/setgid(), but that
removes our ability to re-assume the identity of the original
euid. The solution is swap creds in a child process, preserving the
creds of the parent.
    @rianhunter
    rianhunter committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    e4f29ab View commit details
    Browse the repository at this point in the history

  2. Support unmount FUSE mounts 

    FUSE mounts don't need an fstab entry to be unmounted.
This checks if a mount is a FUSE mount before checking for
the fstab entry, and if so returns success.
    @rianhunter
    rianhunter committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    96c0051 View commit details
    Browse the repository at this point in the history