fix: Replace raw pointer with 'std::unique_ptr'

utilForever · Sep 15, 2020 · c59cb97 · c59cb97
1 parent a8f5748
commit c59cb97
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Extensions/HellPython/Sources/Games/Game.cpp b/Extensions/HellPython/Sources/Games/Game.cpp
@@ -7,6 +7,8 @@
 #include <Games/Game.hpp>
 #include <HellSolver/Games/Game.hpp>
 
+#include <pybind11/stl.h>
+
 using namespace hell_solver;
 
 void AddGame(pybind11::module& m)

diff --git a/Includes/HellSolver/Games/Game.hpp b/Includes/HellSolver/Games/Game.hpp
@@ -10,6 +10,7 @@
 #include <HellSolver/Games/Map.hpp>
 #include <HellSolver/Player/Player.hpp>
 
+#include <memory>
 #include <string_view>
 
 namespace hell_solver
@@ -47,7 +48,7 @@ class Game
  private:
     Map m_map;
 
-    Player* GamePlayer;
+    std::unique_ptr<Player> GamePlayer;
 
     //! Checks an object can move.
     //! \param dir The direction to move.

diff --git a/Sources/HellSolver/Games/Game.cpp b/Sources/HellSolver/Games/Game.cpp
@@ -12,8 +12,8 @@ Game::Game(std::string_view filename)
 {
     m_map.Load(filename);
     Position StartPoint = m_map.GetStartPoint();
-    GamePlayer = new Player(StartPoint.first, StartPoint.second,
-                            m_map.GetInitMoveCount());
+    GamePlayer = std::make_unique<Player>(StartPoint.first, StartPoint.second,
+                                          m_map.GetInitMoveCount());
 }
 
 void Game::Reset()