Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 5 THE_BARRENS cards and fix incorrect the logic of some cards #621

Merged
merged 14 commits into from Aug 8, 2021

Conversation

utilForever
Copy link
Owner

This revision includes:

  • Implement 5 THE_BARRENS cards
    • Flurry (Rank 1) (BAR_305)
    • Runed Orb (BAR_541)
    • Oasis Ally (BAR_812)
    • Rimetongue (BAR_888)
    • Shattering Blast (WC_041)
  • Fix incorrect the logic of some cards (Resolves Fix incorrect the logic of some cards #620)
    • Wound Prey (BAR_801)
      • Remove play requirement 'REQ_MINION_TARGET'
    • Snake Trap (EX1_554)
      • Change the type of variable 'condition' to 'std::vector<std::shared_ptr>' to add several conditions
      • Add method 'IsEventTargetFieldNotFull()': SelfCondition wrapper for checking the field of event target is not full
      • Add unit test code to check the case when the field is full
  • Add method 'IsFrostSpell()': SelfCondition wrapper for checking the entity is frost spell

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #621 (e721d7b) into main (164246e) will decrease coverage by 0.00%.
The diff coverage is 99.54%.

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   97.59%   97.59%   -0.01%     
==========================================
  Files         343      343              
  Lines       61121    61419     +298     
==========================================
+ Hits        59650    59939     +289     
- Misses       1471     1480       +9     

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
31.6% 31.6% Duplication

@utilForever utilForever merged commit fe6cc7e into main Aug 8, 2021
@utilForever utilForever deleted the impl-card branch August 10, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix incorrect the logic of some cards
1 participant