Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to download resources automatically #30

Merged
merged 1 commit into from Oct 14, 2021
Merged

Add script to download resources automatically #30

merged 1 commit into from Oct 14, 2021

Conversation

bignuts
Copy link
Contributor

@bignuts bignuts commented Oct 13, 2021 •
edited by utilForever

This revision includes:

  • Add script to download resources automatically

@utilForever
Copy link
Owner

@bignuts Thanks for contribution! Currently, GitHub Actions has some problems so we'll run CIs after it is fixed.

@utilForever utilForever changed the title Added data_dragon.py to automatically download Resources Add script to download resources automatically Oct 13, 2021
utilForever
utilForever approved these changes Oct 13, 2021
View reviewed changes
Copy link
Owner

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your work! 🎉

@bignuts
Copy link
Contributor Author

bignuts commented Oct 13, 2021

The script can be easily modified to download images if needed, let me know. 💪

SeokminHong
SeokminHong approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@SeokminHong SeokminHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi bignuts! 👋

Thank you for your contribution and it looks good to me!

wojino
wojino approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@wojino wojino left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution. It looks good to me! 👍

@utilForever utilForever merged commit 2fa0ad2 into utilForever:main Oct 14, 2021
@bignuts bignuts deleted the data_dragon branch October 14, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utilForever utilForever utilForever approved these changes

@SeokminHong SeokminHong SeokminHong approved these changes

@wojino wojino wojino approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bignuts @utilForever @SeokminHong @wojino