Fix/icss hashing #52
Fix/icss hashing #52
Conversation
| @@ -1,5 +1,5 @@ | |||
| export var localClass = "n4oS1I"; | |||
| export var localComposes = "i6EUck n4oS1I dgII7d"; | |||
| export var simpleComposes = ""; | |||
There was a problem hiding this comment.
@sylvesteraswin this was definitely wrong before
| export var localComposes = "i6EUck n4oS1I dgII7d"; | ||
| export var simpleComposes = ""; | ||
| export var complexComposes = "i6EUck n4oS1I dgII7d _1RrCqF pQ96hs"; | ||
| export var extend = "_8F86eH" |
There was a problem hiding this comment.
also in these some hashes were missing from the imported ones
| // short circuit: electron definition for a given name is always | ||
| // highest priority and unique source of truth. | ||
| return DEVELOPMENT ? `${name.toUpperCase()}_${hash}` : hash; |
There was a problem hiding this comment.
this return is in the nested function (wakRules) so it doesn't really need a value, but just returning will not override the key later on in this function
| @@ -58,20 +57,6 @@ const generateScopedName: generateScopedName = ({ | |||
| } else { | |||
| pkgName = importedPackage; | |||
| } | |||
| } else if (/:import/.test(rule.selector)) { | |||
There was a problem hiding this comment.
@sylvesteraswin this seem to be the culprit: what was happening basically is that classes in a file with a css import were being evaluated twice with one f the time getting the package name of the imported module (e.g. @my-org/simple-class;withSharedVar).
removing it and returning when rule is a ISS import seems to work fine with the hashes and I also ran the integration tests multiple times to check consstency
|
👍 |
1 similar comment
|
👍 |
@sylvesteraswin