Override hostname on kubelet #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-angel
approved these changes
May 12, 2020
kubelet gets the hostname from the system which on coreos does not include the domain name (it's the short hostname and not the FQDN). This causes the `kubernetes.io/hostname` label to mismatch the node name and is problematic when using Service Topology and potentially other features that use this label. Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
Restarting the service will continuously append to the file Signed-off-by: Dimitrios Karagiannis <dhkarag@gmail.com>
ribbybibby
approved these changes
May 12, 2020
george-angel
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubelet gets the hostname from the system which on coreos does not
include the domain name (it's the short hostname and not the FQDN). This
causes the
kubernetes.io/hostnamelabel to mismatch the node name andis problematic when using Service Topology and potentially other
features that use this label.