-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An error occurred while Packaging/RequireHardcodingLib cop was inspecting file
#44
Comments
Reported this issue to main |
Fixes utkarsh2102#44. Fix a build error when using RuboCop 1.33+. The upstream will be resolved by the release of rubocop/rubocop#10872. Aprt from that, this patch can be resolved by RuboCop::Packaging alone independently from the upstream.
Fixes utkarsh2102#44. Fix a build error when using RuboCop 1.33+. The upstream will be resolved by the release of rubocop/rubocop#10872. Apart from that, this patch can be resolved by RuboCop::Packaging alone independently from the upstream.
Fixes utkarsh2102#44. Fix a build error when using RuboCop 1.33+. The upstream will be resolved by the release of rubocop/rubocop#10872. Apart from that, this patch can be resolved by RuboCop::Packaging alone independently from the upstream.
This issue has been fixed by #43. |
@koic Thanks for the quickest response ) |
@ShockwaveNN You are welcome! Thank you for the quickest feedback too :-) |
@koic Thanks for |
@utkarsh2102 Can you cut a new release to resolve this issue? The issue is already resolved in the master branch. |
…eprecated Fixes rubocop#10871 and utkarsh2102/rubocop-packaging#44. This PR restores `RuboCop::ConfigLoader.project_root` as deprecated. It fixes the following build error. ```console % cd path/to/github.com/utkarsh2102/rubocop-packaging % bundle update && bundle exec rake (snip) Failures: 1) RuboCop::Cop::Packaging::BundlerSetupInTests when `require bundler/setup` is used in a Rakefile does not register an offense Failure/Error: let(:project_root) { RuboCop::ConfigLoader.project_root } NoMethodError: undefined method `project_root' for RuboCop::ConfigLoader:Class # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:6:in `block (2 levels) in <top (required)>' # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:39:in `block (3 levels) in <top (required)>' # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:43:in `block (3 levels) in <top (required)>' ``` I considered a soft deprecation, but decided to issue a warning as it is probably of limited use.
Fixes #10871 and utkarsh2102/rubocop-packaging#44. This PR restores `RuboCop::ConfigLoader.project_root` as deprecated. It fixes the following build error. ```console % cd path/to/github.com/utkarsh2102/rubocop-packaging % bundle update && bundle exec rake (snip) Failures: 1) RuboCop::Cop::Packaging::BundlerSetupInTests when `require bundler/setup` is used in a Rakefile does not register an offense Failure/Error: let(:project_root) { RuboCop::ConfigLoader.project_root } NoMethodError: undefined method `project_root' for RuboCop::ConfigLoader:Class # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:6:in `block (2 levels) in <top (required)>' # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:39:in `block (3 levels) in <top (required)>' # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:43:in `block (3 levels) in <top (required)>' ``` I considered a soft deprecation, but decided to issue a warning as it is probably of limited use.
Super! Thank you, @koic. I'll cut a new release on Sunday/Monday. I'm in midst of flying back home. :) |
…eprecated Fixes rubocop#10871 and utkarsh2102/rubocop-packaging#44. This PR restores `RuboCop::ConfigLoader.project_root` as deprecated. It fixes the following build error. ```console % cd path/to/github.com/utkarsh2102/rubocop-packaging % bundle update && bundle exec rake (snip) Failures: 1) RuboCop::Cop::Packaging::BundlerSetupInTests when `require bundler/setup` is used in a Rakefile does not register an offense Failure/Error: let(:project_root) { RuboCop::ConfigLoader.project_root } NoMethodError: undefined method `project_root' for RuboCop::ConfigLoader:Class # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:6:in `block (2 levels) in <top (required)>' # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:39:in `block (3 levels) in <top (required)>' # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:43:in `block (3 levels) in <top (required)>' ``` I considered a soft deprecation, but decided to issue a warning as it is probably of limited use.
@utkarsh2102 sorry to be a pain, just nudging on this in case it fell through the cracks 🙏 Also, in case you're interested, I use an automated deployment process based on GitHub Releases for my open source projects which allows anyone with permissions to create tags/releases to push a new version to RubyGems without messing with owners. If you're interested let me know and I'd be happy to share |
FYI: RuboCop 1.34 has been released that is the upstream resolved release. However, rubocop-packaging-0.5.1 user will get a deprecation warning. Anyway, the error is resolved. |
👋 @utkarsh2102, I opened one of the PRs to fix this issue (#43), and it is indeed required for
Might be a silly question, but did you forget to run |
@utkarsh2102 all test succeed in CI: https://github.com/utkarsh2102/rubocop-packaging/runs/7754085197?check_suite_focus=true |
Aaah, my bad. I ran into a bunch of stupid problems. But all in all, everything looks good. Thank you very much for the quick fix, @marcotc! ❤️ I've made a new release, v0.5.2 - that should fix the problem. :D |
Closing this issue as everything seems good again but should you run into the same issue (or any other issue), please feel free to re-open or open a new one. Sorry for the slight delay and thank you very much for reporting! \o/ |
@utkarsh2102 Didn't you forgot to make a github release at here? |
Thanks, @ShockwaveNN! I did a draft - wanted to credit everyone before finalizing it. It's live now: https://github.com/utkarsh2102/rubocop-packaging/releases/tag/v0.5.2. :D |
@utkarsh2102 Thank you and thanks for special mention in Changelog ))) |
Thank you @utkarsh2102 🙏 ! |
The issue it resolved has now been released. See utkarsh2102/rubocop-packaging#44
Hi, seems with latest update of
rubocop
to v1.33.0 some changes introduced andrubocop-packaging
started to failError looks like this:
You can reproduce it on my project onlyoffice_webdriver_wrapper
git clone https://github.com/ONLYOFFICE-QA/onlyoffice_webdriver_wrapper.git
cd onlyoffice_webdriver_wrapper && bundle update
rubocop -d
There will be countless failures
Env:
The text was updated successfully, but these errors were encountered: