Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickup task 1177 #29

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Clickup task 1177 #29

merged 3 commits into from
Feb 28, 2024

Conversation

markpbaggett
Copy link
Contributor

Clickup Ticket: Task-1177

What does this Pull Request do?

Adds a rule so that in Firefox, the notes_row contents don't overflow into other sections of the screen.

What's new?

  • Added some instructions on how to build scss to the README.
  • Added a license to package.json to make yarn stop complaining.
  • Added a new rule to custom.scss
  • Regenerated with gulp.

How should this be tested?

I don't think this needs testing, but I would like to know if you have strong feelings that this rule should go elsewhere (another scss file).

If you want to test, follow instructions in the README. If you're using nvm, nvm use 8 first.

Additional Notes:

What about building this with Actions? We should be, but I need to work on something else right now. We will come back to that in another pull request.

Interested parties

@dshaw11

@dshaw11
Copy link

dshaw11 commented Feb 28, 2024

Everything looks correct to me. :shipit:

Copy link

@dshaw11 dshaw11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@markpbaggett markpbaggett merged commit 6a03a62 into master Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants