rsync: cmd: enclose IPv6 hosts in brackets

[Frankkkkk]

Signed-off-by: Frank Villaro-Dixon frank.villaro@infomaniak.com

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

Hi utkuozdemir,

Here's a small MR to handle IPv6 SVCs.

I wanted to to the change inside the template directly but my knowledge of go and the html lib is not excellent. The workaround is not so bad anyways.

Cheers and thanks for your project !

[utkuozdemir]

Hi, thanks for the PR.
Did you try it? Can you see if we can add an integration test for this? It seems kind supports IPv6 dual-stack: https://kind.sigs.k8s.io/docs/user/configuration/#ip-family

[Frankkkkk]

Hi,
to be frank I don't really see the point of a complete integration test, nor do I have the golang-competence to do implement them.

As for the testing, it solves my problem on v6 only clusters.

Cheers

[utkuozdemir]

The base for the integration tests is already there: https://github.com/utkuozdemir/pv-migrate/blob/master/internal/integrationtest/app_test.go

I would rather add one test to verify an ipv6 migration before merging this.
I can look into adding one when I have some time.
Until I do that and make a release with this included, you can use your build.

Thanks