get rid of unused timeout configuration

README.md

@@ -18,11 +18,6 @@ go run ./cmd/entrello -c /path/to/config/file
 
 Most of the configuration parameters are self explanatory, so the following only covers the important ones:
 
-### Global Timeout
-You can edit the `timeout_secs` config value in order to update global timeout (in seconds) for a single execution.
-
-The execution will not terminate until the timeout is reached, so it's important that the timeout is shorter than the cron job period.
-
 ### Trello
 You need to set your [Trello API key & token](https://trello.com/app-key) in the configuraiton file, as well as the Trello board ID.
 

cmd/entrello/main.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"context"
 	"flag"
 	"log"
 	"sync"
@@ -14,7 +13,6 @@ import (
 
 var (
 	logger syslog.Logger
-	now    time.Time
 )
 
 func main() {
@@ -37,15 +35,9 @@ func main() {
 	if err != nil {
 		logger.Fatalf("Invalid timezone location: %v", loc)
 	}
-	now = time.Now().In(loc)
-
-	// set global timeout
-	timeout := time.Second * time.Duration(cfg.TimeoutSeconds)
-	ctx, cancel := context.WithTimeout(context.Background(), timeout)
-	defer cancel()
 
 	// get a list of sources and the corresponding labels for each source
-	sources, labels := getSources(cfg.Sources)
+	sources, labels := getSources(cfg.Sources, time.Now().In(loc))
 	if len(sources) == 0 {
 		return
 	}
@@ -65,7 +57,7 @@ func main() {
 	var wg sync.WaitGroup
 	wg.Add(len(sources))
 	for _, src := range sources {
-		go process(src, ctx, client, &wg)
+		go process(src, client, &wg)
 	}
 	wg.Wait()
 }

cmd/entrello/source.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"context"
 	"encoding/json"
 	"fmt"
 	"io/ioutil"
@@ -14,7 +13,7 @@ import (
 )
 
 // getSources returns a slice of sources & their labels as a separate slice
-func getSources(cfg config.Sources) (sources []config.Source, labels []string) {
+func getSources(cfg config.Sources, now time.Time) (sources []config.Source, labels []string) {
 	arr := []config.Source{
 		cfg.GithubIssues,
 		cfg.TodoDock,
@@ -66,12 +65,12 @@ func shouldQuery(src config.Source, date time.Time) (bool, error) {
 
 // process fetches cards from the source and creates the ones that don't already exist,
 // also deletes the stale cards if strict mode is enabled
-func process(src config.Source, ctx context.Context, client trello.Client, wg *sync.WaitGroup) {
+func process(src config.Source, client trello.Client, wg *sync.WaitGroup) {
 	defer wg.Done()
 
 	resp, err := http.Get(src.Endpoint)
 	if err != nil {
-		logger.Errorf("could not send POST request to source '%s' endpoint: %v", src.Name, err)
+		logger.Errorf("could not make GET request to source '%s' endpoint: %v", src.Name, err)
 		return
 	}
 	defer resp.Body.Close()

config.example.yml

@@ -1,5 +1,4 @@
 timezone_location: Europe/Istanbul
-timeout_secs: 45
 
 trello:
   api_key: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

internal/config/config.go

@@ -48,7 +48,6 @@ type Telegram struct {
 
 type Config struct {
 	TimezoneLocation string   `yaml:"timezone_location"`
-	TimeoutSeconds   int      `yaml:"timeout_secs"`
 	Trello           Trello   `yaml:"trello"`
 	Sources          Sources  `yaml:"sources"`
 	Telegram         Telegram `yaml:"telegram"`