Fix issue #3913

[Halo-Michael]

Fix #3913

[Halo-Michael]

Well, why binary build for arm64, ios_simulator does not have arm64 silce? @osy
CC: https://github.com/utmapp/UTM/runs/6138999484?check_suite_focus=true#step:9:3068

[osy]

I'm not sure, it works fine though so maybe check the file and see what it contains?

[Halo-Michael]

I'm not sure, it works fine though so maybe check the file and see what it contains?

UTM main binary have arm64 silce, but the framework does not.

[Halo-Michael]

I guess we can only lipo for non-simulator build.

[Halo-Michael]

Okey, that's it, the script will cut useless architectures for macOS/iOS now.

[Halo-Michael]

@osy Can you please verify the pull request? Thanks.

[osy]

I'm pretty sure this breaks macOS universal which has both x86_64 and arm64.

Also why are you looking at */Frameworks/*.framework I don't think there's any fat binaries there?

Overall I see the space reduced by 10% to 746MB for iOS. Is that really that big of a deal?

[Halo-Michael]

I'm pretty sure this breaks macOS universal which has both x86_64 and arm64.

Also why are you looking at */Frameworks/*.framework I don't think there's any fat binaries there?

Overall I see the space reduced by 10% to 746MB for iOS. Is that really that big of a deal?

That sounds weried but only remove arm64e silce is not enough to change a fat file into non-fat file, it's still a "fat file" even it may only have one silce:

I guess we can only cut useless silce for iOS?

[osy]

So is there any reason to include .framework?

[Halo-Michael]

So is there any reason to include .framework?

[Halo-Michael]

So is there any reason to include .framework?

Fat binary probably takes up a full 16K as a page table or something else, so why not?

[conath]

Thanks @Halo-Michael file size is important. 👏