-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pixels for Line Height #19
Comments
No. Defiantly not. h1 |
I agree that more modern CSS practice uses %, em's and rem's, but some projects use pixels because of legacy code. Forward thinking is definitely important, but it also doesn't allow for existing codebases that clients might already be using. |
Hi, how could I generate a line-heigth label at all? Currently if i use the Get Typography tool it don't write any lh - do I have to use a special setting? |
@mimamuh Looks like the new version removes line height from the "get typography" feature. |
"get typography" feature merged into the "get property", and using "sp", "pt" and "px" |
Was wondering why the current Line property comes up as a percentage? Think it would be better to have it display pixels, especially for CSS purposes.
What do you think?
The text was updated successfully, but these errors were encountered: