Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pixels for Line Height #19

Closed
megaroeny opened this issue Sep 22, 2014 · 5 comments
Closed

Use pixels for Line Height #19

megaroeny opened this issue Sep 22, 2014 · 5 comments

Comments

@megaroeny
Copy link

Was wondering why the current Line property comes up as a percentage? Think it would be better to have it display pixels, especially for CSS purposes.

What do you think?

@formspiel
Copy link

No. Defiantly not.
Especially for modern CSS you’ll need the unit-less value (it’s percent). Pixels are dead ;-)
Even the font size should be rem (based on 16px base font size—mostly standard).

h1
font-family: $font-1
font-size: 2rem
line-hight: 1.2

@charliesneath
Copy link

I agree that more modern CSS practice uses %, em's and rem's, but some projects use pixels because of legacy code.

Forward thinking is definitely important, but it also doesn't allow for existing codebases that clients might already be using.

@mimamuh
Copy link

mimamuh commented Jul 1, 2015

Hi, how could I generate a line-heigth label at all? Currently if i use the Get Typography tool it don't write any lh - do I have to use a special setting?

@charliesneath
Copy link

@mimamuh Looks like the new version removes line height from the "get typography" feature.

@utom
Copy link
Owner

utom commented Jul 19, 2015

"get typography" feature merged into the "get property", and using "sp", "pt" and "px"

@utom utom closed this as completed Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants