New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/url construction #52

Merged

Dominic-Marcelino merged 2 commits into main from fix/url-construct

Apr 4, 2024

Contributor

Dominic-Marcelino commented Apr 4, 2024 •

edited

Loading

Fix error on relative URLs by using the current origin as fallback.

fix #51

Dominic-Marcelino added 2 commits

April 4, 2024 15:31


          FIX: add current url as default on URL calculation

20808c5


          FIX: set dialog to false on close

027b77e

Dominic-Marcelino mentioned this pull request

Consider URLs with leading slashes as internal without crashing. #51

Closed

Dominic-Marcelino merged commit 3e38c28 into main

Dominic-Marcelino deleted the fix/url-construct branch

April 4, 2024 13:44

JoshTheDerf commented Apr 4, 2024

Ah neat! I had no idea new URL() took a second parameter. Very good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment