-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: DB proxy #1
Conversation
Meldiron
commented
Oct 16, 2023
•
edited
Loading
edited
- Manual QA with Sentry logging
- All tests in utopia/database passed locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a lot of maintenance overhead 😅 we'll need to update any time any parameter in the database library is added, changed, or removed.
Let's make sure all those tests are added and the auth var issues are sorted too 👍
Yes, sadly. We could just proxy it, but we won't have any validators and we would be guessing expected classes. That'ß why we decided to define each endpoint. Thankfully, if you do some change or add new method in utopia-php/database, the DatabaseProxy tests will fails. Thats indicator that you need to add it here too. |