Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: DB proxy #1

Merged
merged 33 commits into from
Feb 27, 2024
Merged

Feat: DB proxy #1

merged 33 commits into from
Feb 27, 2024

Conversation

Meldiron
Copy link
Collaborator

@Meldiron Meldiron commented Oct 16, 2023

  • Manual QA with Sentry logging
    CleanShot 2023-10-17 at 15 24 00@2x
    CleanShot 2023-10-17 at 15 24 29@2x
  • All tests in utopia/database passed locally
    image

@Meldiron Meldiron reopened this Oct 16, 2023
_build.txt Outdated Show resolved Hide resolved
app/Validator/Assoc.php Outdated Show resolved Hide resolved
app/endpoints.php Outdated Show resolved Hide resolved
app/endpoints.php Outdated Show resolved Hide resolved
app/http.php Outdated Show resolved Hide resolved
app/http.php Outdated Show resolved Hide resolved
app/http.php Outdated Show resolved Hide resolved
app/http.php Outdated Show resolved Hide resolved
Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a lot of maintenance overhead 😅 we'll need to update any time any parameter in the database library is added, changed, or removed.

Let's make sure all those tests are added and the auth var issues are sorted too 👍

Dockerfile Outdated Show resolved Hide resolved
app/endpoints.php Outdated Show resolved Hide resolved
app/http.php Outdated Show resolved Hide resolved
app/http.php Outdated Show resolved Hide resolved
app/http.php Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
mariadb.cnf Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
psalm.xml Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
app/endpoints.php Outdated Show resolved Hide resolved
@Meldiron
Copy link
Collaborator Author

This is going to be a lot of maintenance overhead 😅 we'll need to update any time any parameter in the database library is added, changed, or removed.

Yes, sadly. We could just proxy it, but we won't have any validators and we would be guessing expected classes. That'ß why we decided to define each endpoint.

Thankfully, if you do some change or add new method in utopia-php/database, the DatabaseProxy tests will fails. Thats indicator that you need to add it here too.

composer.json Outdated Show resolved Hide resolved
@eldadfux eldadfux merged commit 85812cd into main Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants